[SVLS-8492] Wire durable function event forwarder release from serverless-ci#331
Open
lym953 wants to merge 2 commits into
Open
[SVLS-8492] Wire durable function event forwarder release from serverless-ci#331lym953 wants to merge 2 commits into
lym953 wants to merge 2 commits into
Conversation
Include serverless-ci's durable-function-event-forwarder/gitlab-config.yml so the template under aws_durable_function_event_forwarder/ is published to S3 by a serverless-team-owned job on a merge to master. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lym953
force-pushed
the
yiming.luo/durable-forwarder-release-ci
branch
from
224b9c0 to
73edaaa
Compare
Match the serverless-ci folder rename; reword the comment to describe the release split by location rather than ownership. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lym953
changed the title
lym953
changed the title
There was a problem hiding this comment.
Pull request overview
This PR wires the release process for the Lambda Durable Function event forwarder CloudFormation template into this repo’s GitLab pipeline by including the corresponding release job definition maintained in DataDog/serverless-ci.
Changes:
- Add a GitLab CI
include:that pulls inlambda-durable-function-event-forwarder/gitlab-config.ymlfromDataDog/serverless-ciso the template can be released from this repo’s pipeline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+11
| include: | ||
| - project: DataDog/serverless-ci | ||
| ref: main | ||
| file: lambda-durable-function-event-forwarder/gitlab-config.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The Lambda Durable Function event forwarder template is added in #330. Its release to S3 is handled in
DataDog/serverless-ci(see DataDog/serverless-ci#180).Change
Adds an
include:of serverless-ci'slambda-durable-function-event-forwarder/gitlab-config.ymlso itsrelease-stage job runs in this repo's pipeline.On a merge to
masterthat changesaws_durable_function_event_forwarder/durable_function_event_forwarder.yaml, a manual job publishes the template tos3://datadog-cloudformation-template/aws/lambda-durable-function-event-forwarder/(<version>.yaml+latest.yaml). The job reuses this repo's existing runner credentials, the same ones the otherrelease_*jobs use for that bucket.Testing
Not tested yet. Will test after it's merged to master. No one is using this CloudFormation template so this should be safe.